Skip to content

8361497: Scoped Values: orElse and orElseThrow do not access the cache #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

8361497: Scoped Values: orElse and orElseThrow do not access the cache #142

wants to merge 1 commit into from
+100 −15

Conversation

rgithubli
Copy link
Contributor

@rgithubli rgithubli commented Aug 28, 2025 •
edited by openjdk bot
Loading

Backport of https://bugs.openjdk.org/browse/JDK-8361497

Not clean due to the lack of https://bugs.openjdk.org/browse/JDK-8360884. The cherry pick conflict was caused by the a new test added in the JDK-8360884., code. Based on the conversation in JDK-8360884, it seems people are not comfortable to backport JDK-8360884 into 25 yet. The conflict was easy to resolve tho. Just remove the additional test brought by JDK-8360884.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8361497 needs maintainer approval

Issue

  • JDK-8361497: Scoped Values: orElse and orElseThrow do not access the cache (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/142/head:pull/142
$ git checkout pull/142

Update a local copy of the PR:
$ git checkout pull/142
$ git pull https://git.openjdk.org/jdk25u.git pull/142/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 142

View PR using the GUI difftool:
$ git pr show -t 142

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/142.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 28, 2025

👋 Welcome back rgithubli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 28, 2025 •
edited
Loading

@rgithubli This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361497: Scoped Values: orElse and orElseThrow do not access the cache

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 9dd93c6a2c5fb4c3a9f2a063a7ab402f9292ad03 8361497: Scoped Values: orElse and orElseThrow do not access the cache Aug 28, 2025
@openjdk
Copy link

openjdk bot commented Aug 28, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 28, 2025
@openjdk
Copy link

openjdk bot commented Aug 28, 2025

⚠️ @rgithubli This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 28, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 28, 2025

Webrevs

@rgithubli
Copy link
Contributor Author

rgithubli commented Aug 28, 2025 •
edited
Loading

/approval request for backport of JDK-8361497: Scoped Values: orElse and orElseThrow do not access the cache

Motivation: The current cache in ScopedValue does not update if it's a miss in the cache initially but the binding was found. This behavior slows down the performance of ScopedValue.orElse and ScopedValue.orElseThrow.

Risk: Relatively low. The change is in the tip for over a month. The same time, I do understand we want to make 25 as stable as possible after GA and this patch probably isn't too urgent. If this isn't good for 25u for now, let me know if it's good for 25u-dev once it's available.

@openjdk
Copy link

openjdk bot commented Aug 28, 2025

@rgithubli
8361497: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated labels Aug 28, 2025
@rgithubli
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 2, 2025
@openjdk
Copy link

openjdk bot commented Sep 2, 2025

@rgithubli
Your change (at version 522b9d5) is now ready to be sponsored by a Committer.

@Rudometov
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 2, 2025

Going to push as commit b32786a.
Since your change was applied there have been 9 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 2, 2025
@openjdk openjdk bot closed this Sep 2, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 2, 2025
@openjdk
Copy link

openjdk bot commented Sep 2, 2025

@Rudometov @rgithubli Pushed as commit b32786a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgithubli @Rudometov